Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cipher list option to IMAP config flow #91896

Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Apr 23, 2023

Proposed change

Add cipher list option to IMAP config flow. The new option allows to set an alternative cipherlist.
The PR has the same base as #91078.

The new option allows to select the list of SSL ciphers to be accepted from this endpoint. default (system default), modern or intermediate (inspired by Mozilla Security/Server Side TLS).

The option will only show up if advanced mode is enabled within the user context.

afbeelding

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration (imap) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of imap can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign imap Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, did not recognized this in my previous review

homeassistant/components/imap/config_flow.py Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 23, 2023 13:57
@jbouwh jbouwh marked this pull request as ready for review April 23, 2023 14:19
@home-assistant home-assistant bot requested a review from mib1185 April 23, 2023 14:19
@mib1185 mib1185 marked this pull request as draft April 23, 2023 15:43
@mib1185 mib1185 marked this pull request as ready for review April 23, 2023 15:55
@home-assistant home-assistant bot requested a review from mib1185 April 23, 2023 15:55
@jbouwh
Copy link
Contributor Author

jbouwh commented Apr 23, 2023

@MartinHjelmare are you happy with this?

@jbouwh jbouwh added the smash Indicator this PR is close to finish for merging or closing label Apr 24, 2023
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbouwh jbouwh merged commit 3f6541a into home-assistant:dev Apr 24, 2023
@jbouwh jbouwh deleted the imap-add-ssl_cipher_list-to-config-flow branch April 24, 2023 13:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL error when setting up IMAP email sensors
3 participants