Add Sense Devices for entities #129182
Draft
Add Sense Devices for entities #129182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
reviewed
Oct 25, 2024
joostlek
requested changes
Oct 26, 2024
| model="Sense", | ||
| manufacturer="Sense Labs, Inc.", | ||
| configuration_url="https://home.sense.com", | ||
| via_device=(DOMAIN, f"{sense_monitor_id}"), |
There was a problem hiding this comment.
Suggested change
| via_device=(DOMAIN, f"{sense_monitor_id}"), | |
| via_device=(DOMAIN, sense_monitor_id), |
| model="Sense", | ||
| manufacturer="Sense Labs, Inc.", | ||
| configuration_url="https://home.sense.com", | ||
| via_device=(DOMAIN, f"{sense_monitor_id}"), |
There was a problem hiding this comment.
Suggested change
| via_device=(DOMAIN, f"{sense_monitor_id}"), | |
| via_device=(DOMAIN, sense_monitor_id), |
| @@ -66,6 +67,14 @@ def __init__( | |||
| self._attr_unique_id = f"{sense_monitor_id}-{self._id}" | |||
| self._attr_icon = sense_to_mdi(device.icon) | |||
| self._device = device | |||
| self._attr_device_info = DeviceInfo( | |||
| name=f"Sense {sense_monitor_id} - {device.name}", | |||
There was a problem hiding this comment.
I think we should name this device the device name as that is user recognisable. They can view to which monitor it belongs via the device info page
There was a problem hiding this comment.
Also because i think it's a good idea that we migrate to has entity name = True, where all entity names are appended to the device name
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Creates HA devices for each Sense device
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: