-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sense Devices for entities #129182
base: dev
Are you sure you want to change the base?
Add Sense Devices for entities #129182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split adding the device from adding new sensors? I think it would also be nice to start migrating to has_entity_name = True
after that so we can add translations and stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also make sense to introduce a base entity in entity.py where we deduplicate stuff like the device info
model="Sense", | ||
manufacturer="Sense Labs, Inc.", | ||
configuration_url="https://home.sense.com", | ||
via_device=(DOMAIN, f"{sense_monitor_id}"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
via_device=(DOMAIN, f"{sense_monitor_id}"), | |
via_device=(DOMAIN, sense_monitor_id), |
model="Sense", | ||
manufacturer="Sense Labs, Inc.", | ||
configuration_url="https://home.sense.com", | ||
via_device=(DOMAIN, f"{sense_monitor_id}"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
via_device=(DOMAIN, f"{sense_monitor_id}"), | |
via_device=(DOMAIN, sense_monitor_id), |
@@ -66,6 +67,14 @@ def __init__( | |||
self._attr_unique_id = f"{sense_monitor_id}-{self._id}" | |||
self._attr_icon = sense_to_mdi(device.icon) | |||
self._device = device | |||
self._attr_device_info = DeviceInfo( | |||
name=f"Sense {sense_monitor_id} - {device.name}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should name this device the device name as that is user recognisable. They can view to which monitor it belongs via the device info page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also because i think it's a good idea that we migrate to has entity name = True, where all entity names are appended to the device name
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Creates HA devices for each Sense device
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: