-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reauth config flow title #129134
base: dev
Are you sure you want to change the base?
Fix reauth config flow title #129134
Conversation
Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @matrixd2, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @frenck, @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Could this be trapped as part of the translation checks? core/tests/components/conftest.py Line 537 in 3512cb9
|
There are some integrations that use custom reauth titles (neato, weheat) and others that are missing the title string completely (google_photos, google_tasks, microbees), I did not touch those. |
Yes - but maybe we could adjust the check to say:
Also - I think there is a difference between "title placeholders" and "description placeholders" |
Would be nice, but I'm not familiar with these tests.
Tested and verified with |
I think I got every finding.. |
There are a few where the entry is already available (I haven't checked all as I'm on mobile) so you don't need to do a second lookup. |
Co-authored-by: epenet <[email protected]>
@@ -384,6 +385,7 @@ async def async_step_reauth_confirm( | |||
return self.async_show_form( | |||
step_id="reauth_confirm", | |||
data_schema=data_schema, | |||
description_placeholders={CONF_NAME: self._get_reauth_entry().title}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be handling it this way. Let's see if we can make it smarter and inject name automatically. This is not something every integration should have to do.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Adds missing
name
to reauth title.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: