Fix reauth config flow title #129134

CFenner · 2024-10-25T08:13:56Z

Proposed change

Adds missing name to reauth title.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Translation issue with reauth config flow #129098
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2024-10-25T08:14:04Z

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (point) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of point can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign point Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-10-25T08:14:04Z

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (youtube) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of youtube can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign youtube Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-10-25T08:14:04Z

Hey there @matrixd2, mind taking a look at this pull request as it has been labeled with an integration (yolink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of yolink can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign yolink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-10-25T08:14:04Z

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (netatmo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netatmo can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign netatmo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-10-25T08:14:04Z

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (twitch) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of twitch can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign twitch Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-10-25T08:14:04Z

Hey there @frenck, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (spotify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of spotify can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign spotify Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

epenet · 2024-10-25T08:22:29Z

Could this be trapped as part of the translation checks?

core/tests/components/conftest.py

Line 537 in 3512cb9

    
           def check_config_translations(ignore_translations: str | list[str]) -> Generator[None]:

CFenner · 2024-10-25T08:32:04Z

There are some integrations that use custom reauth titles (neato, weheat) and others that are missing the title string completely (google_photos, google_tasks, microbees), I did not touch those.

epenet · 2024-10-25T08:36:02Z

There are some integrations that use custom reauth titles (neato, weheat) and others that are missing the title string completely (google_photos, google_tasks, microbees), I did not touch those.

Yes - but maybe we could adjust the check to say:

if the step has a title => extract the placeholders => check that flow result/context has necessary placeholders => fail if missing placeholders

Also - I think there is a difference between "title placeholders" and "description placeholders"

CFenner · 2024-10-25T08:39:33Z

Could this be trapped as part of the translation checks?

Would be nice, but I'm not familiar with these tests.

Also - I think there is a difference between "title placeholders" and "description placeholders"

Tested and verified with description_placeholders.

homeassistant/components/notion/config_flow.py

homeassistant/components/caldav/config_flow.py

CFenner · 2024-10-25T11:58:25Z

See #129140 to help identify the instances Already two more reauth_confirm flows affected.

CI run has completed on #129140: https://github.com/home-assistant/core/actions/runs/11516128405 I suggest you take a look to see how many more need adjusting

I think I got every finding..

epenet · 2024-10-25T12:02:29Z

There are a few where the entry is already available (I haven't checked all as I'm on mobile) so you don't need to do a second lookup.
Also renault is using snapshot assertion on the flow result :)

Needs fixes

homeassistant/components/xiaomi_miio/config_flow.py

homeassistant/components/surepetcare/config_flow.py

homeassistant/components/aussie_broadband/config_flow.py

homeassistant/components/jellyfin/config_flow.py

homeassistant/components/jvc_projector/config_flow.py

Co-authored-by: epenet <[email protected]>

frenck · 2024-10-26T00:26:56Z

homeassistant/components/ezviz/config_flow.py

@@ -384,6 +385,7 @@ async def async_step_reauth_confirm(
        return self.async_show_form(
            step_id="reauth_confirm",
            data_schema=data_schema,
+            description_placeholders={CONF_NAME: self._get_reauth_entry().title},


We should not be handling it this way. Let's see if we can make it smarter and inject name automatically. This is not something every integration should have to do.

home-assistant · 2024-10-26T00:27:01Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

fix reauth title

56ae1a1

home-assistant bot added bugfix cla-signed Hacktoberfest integration: netatmo integration: point integration: spotify integration: twitch integration: yolink integration: youtube small-pr PRs with less than 30 lines. labels Oct 25, 2024

home-assistant bot assigned cgtobi, frenck and joostlek Oct 25, 2024

home-assistant bot added Quality Scale: No score Quality Scale: silver labels Oct 25, 2024

fix reauth title

f623d36

fix reauth title

818f923

CFenner marked this pull request as ready for review October 25, 2024 08:57

CFenner requested a review from joostlek as a code owner October 25, 2024 08:57

fix reauth title

1d137a7

CFenner requested review from bachya, ludeeus, chemelli74 and ctalkington as code owners October 25, 2024 11:42

fix reauth title

9a76ae1

CFenner requested review from rytilahti, syssi, starkillerOG and epenet as code owners October 25, 2024 11:49

epenet reviewed Oct 25, 2024

View reviewed changes

homeassistant/components/notion/config_flow.py Outdated Show resolved Hide resolved

epenet reviewed Oct 25, 2024

View reviewed changes

homeassistant/components/caldav/config_flow.py Outdated Show resolved Hide resolved

fix reauth title

fa65fa9

CFenner requested review from Danielhiversen, Quentame and scop as code owners October 25, 2024 11:57

epenet mentioned this pull request Oct 25, 2024

Add checks for flow title placeholders #129140

Draft

19 tasks

CFenner commented Oct 25, 2024

View reviewed changes

CFenner and others added 4 commits October 25, 2024 17:42

Apply suggestions from code review

e9d0aec

Co-authored-by: epenet <[email protected]>

fix test case

41a3379

Merge branch 'dev' into reauth

0796bdf

fix

f30186d

CFenner marked this pull request as draft October 25, 2024 20:55

CFenner marked this pull request as ready for review October 25, 2024 20:55

frenck requested changes Oct 26, 2024

View reviewed changes

home-assistant bot marked this pull request as draft October 26, 2024 00:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix reauth config flow title #129134

Fix reauth config flow title #129134

CFenner commented Oct 25, 2024 •

edited

Loading

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

epenet commented Oct 25, 2024

CFenner commented Oct 25, 2024

epenet commented Oct 25, 2024

CFenner commented Oct 25, 2024

CFenner commented Oct 25, 2024

epenet commented Oct 25, 2024

frenck Oct 26, 2024

home-assistant bot commented Oct 26, 2024

Fix reauth config flow title #129134

Are you sure you want to change the base?

Fix reauth config flow title #129134

Conversation

CFenner commented Oct 25, 2024 • edited Loading

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

home-assistant bot commented Oct 25, 2024

epenet commented Oct 25, 2024

CFenner commented Oct 25, 2024

epenet commented Oct 25, 2024

CFenner commented Oct 25, 2024

CFenner commented Oct 25, 2024

epenet commented Oct 25, 2024

frenck Oct 26, 2024

Choose a reason for hiding this comment

home-assistant bot commented Oct 26, 2024

CFenner commented Oct 25, 2024 •

edited

Loading