-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Weheat temperature sensors #128452
Add missing Weheat temperature sensors #128452
Conversation
Hey there @jesperraemaekers, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Not sure why the tests are failing. I also wanted to add:
But the first 2 are not exposed as property, only the latter: https://github.com/wefabricate/wh-python/blob/d39f233f78ea01394c238225dbc0b92edba0558f/weheat/abstractions/heat_pump.py#L175 |
run |
I already did that, but it seems I needed to run |
Ah, the translations were not generated |
Adds the sensors added in home-assistant/core#128452
WeHeatSensorEntityDescription( | ||
translation_key="thermostat_room_temperature", | ||
key="thermostat_room_temperature", | ||
native_unit_of_measurement=UnitOfTemperature.CELSIUS, | ||
device_class=SensorDeviceClass.TEMPERATURE, | ||
state_class=SensorStateClass.MEASUREMENT, | ||
suggested_display_precision=DISPLAY_PRECISION_WATER_TEMP, | ||
value_fn=lambda status: status.thermostat_room_temperature, | ||
), | ||
WeHeatSensorEntityDescription( | ||
translation_key="thermostat_room_temperature_setpoint", | ||
key="thermostat_room_temperature_setpoint", | ||
native_unit_of_measurement=UnitOfTemperature.CELSIUS, | ||
device_class=SensorDeviceClass.TEMPERATURE, | ||
state_class=SensorStateClass.MEASUREMENT, | ||
suggested_display_precision=DISPLAY_PRECISION_WATER_TEMP, | ||
value_fn=lambda status: status.thermostat_room_temperature_setpoint, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this only support 1 room?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <[email protected]>
For completeness also add the sensors to icons.json and then it is good to go @barryvdh |
Oh good point, but we should only do that if the default icons don't suffice |
I added home-thermometer for the room temperatures, and the default thermometer for the water target. |
Every entity with device class temperature has |
Thanks @barryvdh ! |
Adds the sensors added in home-assistant/core#128452
Proposed change
Add more attributes, that are already available in the upstream library (https://github.com/wefabricate/wh-python/blob/2024.09.23/weheat/abstractions/heat_pump.py)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: