Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for valid abort reason translation in option flows #128444

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Oct 15, 2024

Proposed change

As follow-up to #128140, add checks for abort reasons in OptionsFlowManager

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet changed the title Add translation checks for abort result in options flows Add check for valid abort reason translation in option flows Oct 15, 2024
@epenet epenet marked this pull request as ready for review October 15, 2024 14:12
@epenet epenet requested a review from a team as a code owner October 15, 2024 14:12
@frenck frenck merged commit c5046f7 into home-assistant:dev Oct 16, 2024
45 checks passed
@epenet epenet deleted the 20241015-1458 branch October 16, 2024 11:42
@epenet epenet mentioned this pull request Oct 16, 2024
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants