Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation string in hyperion #128384

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix translation string in hyperion #128384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64b4f50
Fix translation string in hyperion
j4n-e4t Oct 14, 2024
71119e4
Merge branch 'dev' into j4n-e4t/translations-hyperion
j4n-e4t Oct 16, 2024
782e5f0
Remove ignore_translations from hyperion config_flow test
j4n-e4t Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions homeassistant/components/hyperion/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@
"effect_show_list": "Hyperion effects to show"
}
}
},
"abort": {
"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]"
j4n-e4t marked this conversation as resolved.
Show resolved Hide resolved
}
},
"entity": {
Expand Down
5 changes: 0 additions & 5 deletions tests/components/hyperion/test_config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from unittest.mock import AsyncMock, Mock, patch

from hyperion import const
import pytest

from homeassistant.components import ssdp
from homeassistant.components.hyperion.const import (
Expand Down Expand Up @@ -824,10 +823,6 @@ async def test_options_effect_show_list(hass: HomeAssistant) -> None:
assert result["data"][CONF_EFFECT_HIDE_LIST] == ["effect2"]


@pytest.mark.parametrize( # Remove when translations fixed
"ignore_translations",
["component.hyperion.options.abort.cannot_connect"],
)
async def test_options_effect_hide_list_cannot_connect(hass: HomeAssistant) -> None:
"""Check an options flow effect hide list with a failed connection."""

Expand Down