-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Solarlog unmaintained library #117484
Replace Solarlog unmaintained library #117484
Conversation
Update async_migrate_entry
Hey there @Ernst79, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@coderabbitai review |
Actions PerformedReview triggered.
|
WalkthroughThe updates focus on the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@edenhaus : Have you already had a chance to review the requested changes? |
Co-authored-by: Robert Resch <[email protected]>
Sanity check |
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the CI
There is one pytest failing, but according to my understanding this is not related to the PR. Can you please confirm? |
Looks like it times out. You could try to rerun the test later today. But it seems indeed unrelated. |
@edenhaus : CI fixed, do you have further comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dontinelli 👍
Breaking change
Proposed change
This PR changes to a new library for gathering the data from the Solar-Log device. Background is that the old library is not maintained anymore. With the new library, new data points can be accessed (such as self-consumption, specific data per inverter). This PR only covers the change in library and the new config entry ("extended_data) - including the migration flow - and the updated tests, any additional data will be added with subsequent PR.
Path to new libary: https://github.com/dontinelli/solarlog_cli
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: