Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom integration: HydroPeak #6329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Beat-YT
Copy link

@Beat-YT Beat-YT commented Jan 5, 2025

Proposed change

Add a picture of for my integration called Hydro-Peak, monitoring the quebec power utility peak events to save on the electrical bill.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue:
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/Beat-YT/hydropeak-ha

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@Beat-YT Beat-YT changed the title Add HydroPeak custom integration custom integration: HydroPeak Jan 5, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided icon looks like a modified version of the upstream branding?

CleanShot 2025-01-05 at 13 08 31

Is that a correct observation?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 5, 2025 12:09
@home-assistant
Copy link

home-assistant bot commented Jan 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Beat-YT
Copy link
Author

Beat-YT commented Jan 5, 2025

The provided icon looks like a modified version of the upstream branding?

is that a problem ?

@Beat-YT Beat-YT marked this pull request as ready for review January 6, 2025 01:45
@home-assistant home-assistant bot requested a review from frenck January 6, 2025 01:45
@Beat-YT
Copy link
Author

Beat-YT commented Jan 6, 2025

The provided icon looks like a modified version of the upstream branding?
Is that a correct observation?

I changed to the original logo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants