Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't error if data does not have name attribute #7655

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 22, 2025

@holovizbot
Copy link

This pull request has been mentioned on HoloViz Discourse. There might be relevant details there:

https://discourse.holoviz.org/t/issue-with-reactivehtml-components-in-panel-1-5-5/8522/4

@hoxbro hoxbro enabled auto-merge (squash) January 22, 2025 16:06
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (dad982b) to head (ef64f97).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7655      +/-   ##
==========================================
+ Coverage   86.77%   86.78%   +0.01%     
==========================================
  Files         346      346              
  Lines       52225    52232       +7     
==========================================
+ Hits        45318    45332      +14     
+ Misses       6907     6900       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro disabled auto-merge January 22, 2025 17:31
@philippjfr philippjfr enabled auto-merge (squash) January 22, 2025 17:59
@philippjfr philippjfr merged commit 663df35 into main Jan 22, 2025
18 checks passed
@philippjfr philippjfr deleted the fix_dont_error branch January 22, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants