refactor: Remove direct pandas import #6476
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
force-pushed
the
remove_direct_pandas
branch
from
7fc6d1d to
dc063df
Compare
hoxbro
commented
Dec 13, 2024
| @@ -23,13 +23,26 @@ class PandasAPI: | |||
| ... | |||
| """ | |||
|
|
|||
| pd = None # Set when PandasInterface.applies is successful | |||
There was a problem hiding this comment.
Does not seem to work with test-gpu 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, to see what it would take not to do any direct imports of pandas.
This is doing the minimum effort. Probably, some of the functions that depend on pandas can be rewritten to not need to depend on it.
Import time comparison with Tuna (
python -X importtime -c 'import holoviews' 2> tuna.log && tuna tuna.log):After:
Before:
