-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify dev tooling, remove colorcet examples
, drop 3.7, add 3.12
#120
Conversation
colorcet examples
colorcet examples
, drop 3.7, add 3.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed in HoloViews that there is some size difference between matplotlib on conda and pip. I think it is around 2px, which could be the difference you are seeing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems much simpler, thanks. I'm not sure how examples are meant to be obtained now, but I guess it's via the website?
@jbednar are you ok to merge? |
Colorcet is a simple package, its dev tooling and infra can be simplified. Principles adopted:
As a consequence:
setuptools_scm
insteaddropped 3.7 as for some reason(edit: fixed), and added 3.12 since it was easy.pip install -e .
wouldn't work on this versionI removed the
colorcet examples
CLI as it was one less thing to migrate moving from setup.py to pyproject.toml. I guess I could add it again if we want to keep it, although it's a bit annoying as I also moved all the notebook files from /examples to /doc to build with Sphinx directly. Note that Panel removedpanel examples
is version 1.0.I thought about moving to hatch/hatchling too in this PR but stuck to setuptools for now, it made my life easier. But from this point on it should be pretty easy to convert to hatch/hatchling if need be.
A change I noticed is that now the sdist has all the tracked files in the repository while it contained less files. This is because
setuptools_scm
provide a list of all tracked files tosetuptools
. It could be reduced by pruning dirs and files inMANIFEST.in
. I don't see a need to do that.EDIT:
Happy to report that all the three Github workflows are working with this setup. Also, for some reason I had to update a couple of base images in 012124e. The diff shows that it had something to do with the font more than with the palette.