Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dev tooling, remove colorcet examples, drop 3.7, add 3.12 #120

Merged
merged 27 commits into from
Feb 28, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Feb 11, 2024

Colorcet is a simple package, its dev tooling and infra can be simplified. Principles adopted:

  • Keeps things very simple
  • Use very standard tools

As a consequence:

  • conda is only used when the conda package is built and pushed to pyviz, otherwise it's pip
  • no more pyctdev, simple commands are called directly
  • no more custom versioning, use setuptools_scm instead
  • the site is no longer built directly with nbsite but with sphinx instead
  • pyproject.toml only instead of setup.py + setup.cfg
  • dropped 3.7 as for some reason pip install -e . wouldn't work on this version (edit: fixed), and added 3.12 since it was easy.

I removed the colorcet examples CLI as it was one less thing to migrate moving from setup.py to pyproject.toml. I guess I could add it again if we want to keep it, although it's a bit annoying as I also moved all the notebook files from /examples to /doc to build with Sphinx directly. Note that Panel removed panel examples is version 1.0.

I thought about moving to hatch/hatchling too in this PR but stuck to setuptools for now, it made my life easier. But from this point on it should be pretty easy to convert to hatch/hatchling if need be.

A change I noticed is that now the sdist has all the tracked files in the repository while it contained less files. This is because setuptools_scm provide a list of all tracked files to setuptools. It could be reduced by pruning dirs and files in MANIFEST.in. I don't see a need to do that.

EDIT:

Happy to report that all the three Github workflows are working with this setup. Also, for some reason I had to update a couple of base images in 012124e. The diff shows that it had something to do with the font more than with the palette.

result-failed-diff
result-failed-diff2

@maximlt maximlt changed the title Simplify dev tooling and remove colorcet examples Simplify dev tooling, remove colorcet examples, drop 3.7, add 3.12 Feb 11, 2024
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed in HoloViews that there is some size difference between matplotlib on conda and pip. I think it is around 2px, which could be the difference you are seeing.

colorcet/__init__.py Show resolved Hide resolved
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems much simpler, thanks. I'm not sure how examples are meant to be obtained now, but I guess it's via the website?

@maximlt
Copy link
Member Author

maximlt commented Feb 19, 2024

@jbednar are you ok to merge?

@jbednar jbednar merged commit 9a75298 into main Feb 28, 2024
19 checks passed
@jbednar jbednar deleted the simplify_infra branch February 28, 2024 20:24
This was referenced Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants