Skip to content

Commit

Permalink
Fix holoviews opts deprecation warning (#94)
Browse files Browse the repository at this point in the history
* Updated holoviews option syntax to avoid deprecated API
* Fixed typos
* Removed windows 3.6 case from test suite due to lack of mamba support
  • Loading branch information
jbednar authored Sep 30, 2022
1 parent 8bead89 commit bca9db5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
os: ['ubuntu-latest', 'macos-latest']
python-version: ['3.6']
timeout-minutes: 60
defaults:
Expand Down
4 changes: 2 additions & 2 deletions colorcet/plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def swatches(*args, group=None, not_group=None, only_aliased=False, cols=None, *
swatch(*arg, **kwargs) for
arg in args]

plot = hv.Layout(images).opts(plot=dict(transpose=True)).cols(int(np.ceil(len(images)*1.0/cols)))
plot = hv.Layout(images).opts(transpose=True).cols(int(np.ceil(len(images)*1.0/cols)))

if 'matplotlib' in backends:
plot.opts(opts.Layout(backend='matplotlib', sublabel_format=None,
Expand Down Expand Up @@ -106,7 +106,7 @@ def sine_combs(*args, group=None, not_group=None, only_aliased=False, cols=1, **
sine_comb(*arg, **kwargs) for
arg in args]

plot = hv.Layout(images).opts(plot=dict(transpose=True)).cols(int(np.ceil(len(images)*1.0/cols)))
plot = hv.Layout(images).opts(transpose=True).cols(int(np.ceil(len(images)*1.0/cols)))

backends = hv.Store.loaded_backends()
if 'matplotlib' in backends:
Expand Down
4 changes: 2 additions & 2 deletions examples/index.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@
"For instance, mpl's colormaps are always perceptually uniform in their\n",
"monochrome representation, not just their original color\n",
"representation, and are safe for colorblind viewers, neither of which\n",
"are necessarily true of these colormaps. On the other hand, colormaps\n",
"like \"fire\" above, i.e., a usable perceptually equivalent of\n",
"is necessarily true of these colormaps. On the other hand, colormaps\n",
"like \"fire\" above, i.e., a usable perceptually equivalent version of\n",
"matplotlib/matlab's \"hot\", are not obtainable using viscm in any\n",
"straightforward way, limiting the range of useful colormaps that can be created.\n",
"In any case, this package focuses on making a set of useful colormaps\n",
Expand Down

0 comments on commit bca9db5

Please sign in to comment.