drop 3.7 and try all python versions

holoviz · Feb 11, 2024 · bab3cad · bab3cad
1 parent 012124e
commit bab3cad
Showing 1 changed file with 3 additions and 12 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -30,7 +30,8 @@ jobs:
       matrix:
         os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
         # Run on the full set on schedule, workflow_dispatch and push&tags events, otherwise on a subset.
-        python-version: ${{ ( github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || ( github.event_name == 'push' && github.ref_type == 'tag' ) ) && fromJSON('["3.7", "3.8", "3.9", "3.10", "3.11"]') || fromJSON('["3.7", "3.11"]') }}
+        # python-version: ${{ ( github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || ( github.event_name == 'push' && github.ref_type == 'tag' ) ) && fromJSON('["3.8", "3.9", "3.10", "3.11", "3.12"]') || fromJSON('["3.8", "3.12"]') }}
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     timeout-minutes: 60
     defaults:
       run:
@@ -51,20 +52,10 @@ jobs:
           allow-prereleases: true
       - name: pip update
         run: pip install --upgrade pip
-      - name: install (patch 3.7)
-        if: matrix.python-version == '3.7'
-        # Got this error with setuptools/setuptools_scm on 3.7 that can be "fixed" with --no-build-isolation.
-        # File "/tmp/pip-build-env-64dq88_c/overlay/lib/python3.7/site-packages/setuptools_scm/config.py", line 216, in from_file
-        # return cls(relative_to=name, **args)
-        # TypeError: __init__() got an unexpected keyword argument 'version_file'
-        run: |
-          pip install wheel
-          pip install -e ."[tests,tests_examples,tests_extra]" --no-build-isolation
       - name: pip list
         run: pip list
       - name: install
-        if: matrix.python-version != '3.7'
-        run: SETUPTOOLS_ENABLE_FEATURES="legacy-editable" pip install -e ."[tests,tests_examples,tests_extra]"
+        run: pip install -e ."[tests,tests_examples,tests_extra]"
       - name: unit tests
         run: pytest colorcet --cov=colorcet   --cov-append --cov-report xml
       - name: examples tests