Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/go disable buildvcs #60

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

mattyg
Copy link
Member

@mattyg mattyg commented Oct 8, 2023

This adds the flag -buildvcs=false to go build commands. I don't understand why, but running cargo run in a docker compose command fails due to an error thrown by this buildvcs feature. Edit: I figured out a workaround to avoid this.

My vague understanding is that the buildvcs feature attaches your version control system's current commit hash onto the built binary. Not sure if this is useful, since we're just wrapping the binary within another anyway. If it is necessary let me know and I'll work around it.

This is how the go manpage explains it:

-buildvcs
	Whether to stamp binaries with version control information
	("true", "false", or "auto"). By default ("auto"), version control
	information is stamped into a binary if the main package, the main module
	containing it, and the current directory are all in the same repository.
	Use -buildvcs=false to always omit version control information, or
	-buildvcs=true to error out if version control information is available but
	cannot be included due to a missing tool or ambiguous directory structure.

Copy link
Collaborator

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it seems correct to set this to false.

@neonphog neonphog enabled auto-merge October 10, 2023 19:34
@neonphog neonphog added this pull request to the merge queue Oct 10, 2023
Merged via the queue into holochain:main with commit 80c4e80 Oct 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants