Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the app timeout #116

Merged
merged 3 commits into from
Jan 20, 2025
Merged

remove the app timeout #116

merged 3 commits into from
Jan 20, 2025

Conversation

neonphog
Copy link
Collaborator

@neonphog neonphog commented Jan 14, 2025 •
edited
Loading

RESOLVES: #112

@neonphog neonphog marked this pull request as ready for review January 14, 2025 21:29
@neonphog neonphog requested a review from a team January 14, 2025 21:30
jost-s
jost-s approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I read this as "whenever a send of almost any kind fails, close the connection".

I guess that it's up to the tx5 consumer to re-open the connection when it's closed due to inactivity.

ThetaSinner
ThetaSinner approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of questions about whether there's useful information to be reported from errors

crates/tx5-connection/src/webrtc/libdatachannel.rs Show resolved Hide resolved
crates/tx5-connection/src/webrtc/libdatachannel.rs Show resolved Hide resolved
@neonphog neonphog merged commit 6370830 into main Jan 20, 2025
7 checks passed
@neonphog neonphog deleted the rm-timeout branch January 20, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

@ThetaSinner ThetaSinner ThetaSinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "slow app timeout" with bounded channels
3 participants
@neonphog @ThetaSinner @jost-s