Switch to add_parsable_certificates #114
Conversation
matthme
changed the title
|
According to the documentation the add method is apparently known to fail for some certificates so I switched to the add_parsable_certificates method instead now. |
crates/tx5-signal/Cargo.toml
Outdated
| @@ -31,8 +31,6 @@ tokio-tungstenite = { workspace = true } | |||
| tracing = { workspace = true } | |||
| tx5-core = { workspace = true } | |||
| url = { workspace = true } | |||
|
|
|||
| [target.'cfg(not(any(target_os = "windows", target_os = "linux", target_os = "macos")))'.dependencies] | |||
There was a problem hiding this comment.
This doesn't appear to be platform specific in any way, but it looks like it was deliberately only included for platforms that won't have a certificate store. Now that we're successfully using the certificate store on windows and this isn't being used on the platforms it's been included for, should this be reverted?
There was a problem hiding this comment.
Yes, this should be reverted. rustls_native_certs doesn't currently work on android or ios. (although it'd be nice if it did : )
There was a problem hiding this comment.
Oh yes, sorry. I added this with the initial approach where the certs would be bundled.
|
Tested on Windows where this was crashing for me, confirmed that this solves the problem and I can still make connections |
Should address holochain/holochain#4418