Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration with Holochain after data path changes #193

Merged
merged 15 commits into from
Jan 26, 2024
Merged

Fix integration with Holochain after data path changes #193

merged 15 commits into from
Jan 26, 2024

Conversation

ThetaSinner
Copy link
Member

No description provided.

@ThetaSinner
Copy link
Member Author

Specifically this change broke the integration holochain/holochain#3025

@ThetaSinner ThetaSinner marked this pull request as draft December 21, 2023 12:48
@ThetaSinner ThetaSinner removed the request for review from jost-s December 21, 2023 12:48
@ThetaSinner
Copy link
Member Author

It also looks like we hadn't dealt with the enum serialisation problems yet for 0.3

@ThetaSinner
Copy link
Member Author

We're seeing Conductor returned an error while using a ConductorApi: CellNetworkNotReady(PendingJoin(Failed)) on here which is the same problem AD4M are reporting happens sometimes. We could do with spending some time chasing that one down

@jost-s jost-s marked this pull request as ready for review January 25, 2024 23:16
@jost-s jost-s merged commit 9a89730 into develop Jan 26, 2024
2 checks passed
@jost-s jost-s deleted the fix/integration-with-latest-holochain-changes branch January 26, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaSinner @jost-s