Build/wasmer 5 bump #126
Merged
Build/wasmer 5 bump #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
reviewed
Nov 26, 2024
|
|
||
| # Temporarily include a fork of wasmer from the git branch 'wamr', until it is officially released in wasmer v5 | ||
| hc-wasmer = { version="=4.3.6-hc.1", optional = true, default-features = false } | ||
| wasmer = { version = "5.0.2", default-features = false } |
There was a problem hiding this comment.
Should this stay pinned? Really depends how good we think wasmer are at managing breaking changes
There was a problem hiding this comment.
It looks like we've been pinning the wasmer version since the first release of this crate (when wasmer versioning was at 0.x). I'm not sure what the rationale was, but it doesn't look like it was in response to a specific case where wasmer broke semver.
Idk maybe we should remove the pin and re-add it if there is an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #121