refactor: bypass serialized cache in wasmer_wamr flag #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no utility to caching serialized wasms as they are not pre-compiled. Attempting to use a previously pre-compiled wasm in the interpreter engine will fail.
|
Closing in favor of a different approach where the caches are not used in holochain, rather than being used but not actually caching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
wasmer_wamrflag, there is no utility to caching serialized wasms as they are not pre-compiled.Attempting to use a previously pre-compiled wasm with the flag
wasmer_wamrwill fail. This could possibly arise if a user caches some wasms to holochain data directory from a holochain conductor withwasmer_sysenabled, and then attempts to use the same data directory in a conductor withwasmer_wamrenabled.This PR modifies the ModuleCache and SerializedModuleCache to simply bypass actual caching functionality with the feature flag
wasmer_wamr