Refactor/clarify dylib ios functionality #118
Conversation
…d modules and more clarifying comments
| @@ -385,16 +385,6 @@ impl ModuleCache { | |||
| } | |||
| } | |||
|
|
|||
| /// Configuration of a Target for wasmer for iOS | |||
| pub fn wasmer_ios_target() -> Target { | |||
There was a problem hiding this comment.
this function does not appear to be used anywhere in consuming crates
There was a problem hiding this comment.
This was added by @jost-s, was it something that used to be in Holochain core and got moved here? That's what I vaguely remember. If so, was it something that Guillem was using?
There was a problem hiding this comment.
Yes I think that's right -- I don't see it used anywhere https://github.com/search?q=wasmer_ios_target&type=code
But actually now I realized that parts of this functionality aren't working so I'm not sure it was ever really tested or used. I'm going to wait to merge this PR and see if more changes needed to this crate first.
| ); | ||
| /// Compile a wasm binary, serialize it with wasmer's serializtion format, and write to a file. | ||
| /// This file can later be used for contexts where JIT compilation is not possible (iOS for example). | ||
| pub fn write_precompiled_serialized_module_to_file( |
There was a problem hiding this comment.
Remove references to iOS in function name and comments, as this functionality can be used in other platforms as well
Co-authored-by: Jost Schulte <[email protected]>
Co-authored-by: Jost Schulte <[email protected]>
Co-authored-by: Jost Schulte <[email protected]>
…alized wasm bytes
Co-authored-by: Jost Schulte <[email protected]>
…:holochain/holochain-wasmer into refactor/clarify-dylib-ios-functionality
|
So it looks like the entire functionality to prebuild and include precompiled wasms as dylibs was borked during integration. I believe the wasms do need to be explicitly precompiled for the ios target (and any other target they would be executed on), and so this PR actually doesn't make sense. I'm going to close this and revisit re-implementing or removing that functionality entirely in a subsequent PR when I can put some time towards it. |
Change function names and comments to clarify that precompiled & serialized modules can be used on any platform, not just ios.