Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buildbot-nix): configure postBuildSteps to sign and upload to holo's cache #172

Merged
merged 5 commits into from
Oct 31, 2024
Merged

feat(buildbot-nix): configure postBuildSteps to sign and upload to holo's cache #172

merged 5 commits into from
Oct 31, 2024

Conversation

steveej
Copy link
Member

@steveej steveej commented Oct 19, 2024 •
edited
Loading

requirements for the postBuildStep impl:

  • restrict to trusted owners
  • use a typed application
  • signs holo-host code with holo's keys
  • uploads holo-host code to holo's s3 cache bucket
  • rewrite include/exclude filters per project
  • resolve all TODOs
  • add (integration) test
  • remove initial test conditions
  • squash commits

@steveej steveej marked this pull request as draft October 19, 2024 18:32
@steveej steveej added the enhancement New feature or request label Oct 21, 2024
@steveej steveej self-assigned this Oct 21, 2024
@steveej steveej force-pushed the buildbot-postsbuildsteps branch 2 times, most recently from 1615ba1 to 9cdeeb4 Compare October 30, 2024 20:41
@steveej steveej marked this pull request as ready for review October 30, 2024 20:43
@steveej steveej force-pushed the buildbot-postsbuildsteps branch 2 times, most recently from dd52112 to 8a2d3e8 Compare October 31, 2024 12:24
@steveej steveej merged commit 2bfab86 into develop Oct 31, 2024
2 checks passed
@steveej steveej deleted the buildbot-postsbuildsteps branch October 31, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveej steveej

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steveej