Add vrrp topology. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the topoloy and scripts for vrrp in holo and frr. Signed-off-by: Paul Wekesa <[email protected]>
rwestphal
reviewed
Nov 2, 2024
vrrp/frr/frr-setup.sh
Outdated
|
|
||
|
|
||
| # Wait for the daemons to start | ||
| sleep 5 |
There was a problem hiding this comment.
It seems we have two "sleep" lines that could be combined into one.
rwestphal
reviewed
Nov 2, 2024
vrrp/topology.yml
Outdated
|
|
||
| nodes: | ||
|
|
||
| sw1: |
There was a problem hiding this comment.
Please use "br1" to be consistent with the other topologies. Similarly, please use "rt1" instead of "rt-1".
Rename the connecting devices based on holo's standards. Signed-off-by: Paul Wekesa <[email protected]>
|
@rwestphal worked on the recommendations above in latest commit. Kindly let me know if there are any other changes to be made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the topoloy and scripts for vrrp in holo and ability to test it's inter-operability with frr.