Disallow write transactions on core snapshots (#60)

* Disallow write transactions on snapshots * Throw when creating tx (simplify)
holepunchto · Jan 15, 2025 · 24a91e1 · 24a91e1
1 parent e26f7cc
commit 24a91e1
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/tx.js b/lib/tx.js
@@ -16,6 +16,7 @@ const CORE_HINTS = schema.getEncoding('@core/hints')
 
 class CoreTX {
   constructor (core, db, view, changes) {
+    if (db.snapshotted) throw new Error('Cannot open core tx on snapshot')
     this.core = core
     this.db = db
     this.view = view

diff --git a/test/core.js b/test/core.js
@@ -630,3 +630,23 @@ test('delete bitfield page range', async (t) => {
     t.is(b4a.toString(data4), 'bitfield-data-4')
   }
 })
+
+test('cannot open tx on snapshot', async (t) => {
+  const core = await createCore(t)
+
+  const snap = core.snapshot()
+  t.exception(
+    () => snap.write(),
+    /Cannot open core tx on snapshot/
+  )
+})
+
+test('cannot create sessions on snapshot', async (t) => {
+  const core = await createCore(t)
+  const snap = core.snapshot()
+
+  await t.exception(
+    async () => await snap.createSession(),
+    /Cannot open core tx on snapshot/
+  )
+})