Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep variable selection results of subsamples and visualize #20

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gokceneraslan
Copy link
Contributor

@gokceneraslan gokceneraslan commented Nov 28, 2016

I added a new option, keep.subsampling = FALSE to stabsel function to keep binary subsample variable selection matrix, so that users can visualize subsampling results. For that, I added a third option to plot function, type="subsamples" which uses pheatmap package to plot a heatmap. Code looks like this:

> stab.lasso <- stabsel(x = bodyfat[, -2], y = bodyfat[,2],
                         fitfun = lars.lasso, cutoff = 0.75,
                         PFER = 1, keep.subsampling=T)
> plot(stab.lasso, type='subsamples')

and output is as follows:

image

Does it make sense to provide a way of visualizing subsample selection results like this?

@hofnerb
Copy link
Owner

hofnerb commented Dec 1, 2016

In general I like the idea as it provides new ways to look at the model and at the stability selection results. Things I don't like that much:

  • Currently, the documentation of new argument keep.subsampling and new option type = "subsamples" is missing.

  • The package requires another dependency. Is it possible to realize the plot without pheatmap? If not, please fix:

    checking dependencies in R code ... WARNING
    '::' or ':::' import not declared from: 'pheatmap'
    'loadNamespace' or 'requireNamespace' call not declared from: 'pheatmap'
    
  • The current legend is not really appropriate. Is it possible to provide a binary legend (perhaps also with names "selected" / "not selected") instead?
    legend

@hofnerb
Copy link
Owner

hofnerb commented Dec 12, 2016

@gokceneraslan (when) will you be able to have a look at the remaining issues?

@gokceneraslan
Copy link
Contributor Author

I'll have time next week to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants