-
Notifications
You must be signed in to change notification settings - Fork 48
Adjust testing state, enhance exception context, fix PCRE issue #114
base: master
Are you sure you want to change the base?
Conversation
ohader
commented
Oct 6, 2020
- TravisCI configuration for getting tests "green" - there's more to do in terms of resolving inter-package dependencies and their version constraints ("dependency hell")
- fixes issue Enhance context output of UnrecognizedToken exception #111
- fixes issue Enhance context output of UnexpectedToken exception #112
- fixes issue Unexpected namespace assignment for PCRE containing colon #113
* exclude PHP 7.4 build (not supported by released hoa/test version) * restrict php-cs-fixer to PHP 7.1 max, requires additional `--allow-risky` for newer 2.x releases see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/23ec31224005ee0ed09505eca1bc8af90b7ca557/UPGRADE.md
* enhances `UnrecognizedToken` exception, see hoaproject#111 * enhances `UnexpectedToken` exception, see hoaproject#112 Fixes: hoaproject#111, hoaproject#112
IF this gets stuck, there's this fork. I'll be happy to review a PR. I already did PHP 7.4 there IIRC. |
Thx & good to know... reading other announcements of this project currently not being actively maintained would lead to the conclusion this PR is laying here forever. I'm a fan of try to centralize those things with the upstream repository. Let's see, maybe there are also some possibilities (really) merging your compatibility changes into this repository... |
Well, if you could get a hand on that sweet merge button here, we can certainly try something. But, tbh, I was primarily concerned with |
I'd love that too, but considering that last PR was merged here in 2018, I'd say we'll have a tough luck here. |
I see, I also considered using a "hard-wired" parser, but then found this project again... |