Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Adjust testing state, enhance exception context, fix PCRE issue #114

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ohader
Copy link

@ohader ohader commented Oct 6, 2020

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 14a4ca7 on ohader:master into c620f44 on hoaproject:master.

@coveralls
Copy link

coveralls commented Oct 6, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 14a4ca7 on ohader:master into c620f44 on hoaproject:master.

@sanmai
Copy link

sanmai commented Oct 6, 2020

IF this gets stuck, there's this fork. I'll be happy to review a PR.

I already did PHP 7.4 there IIRC.

@ohader
Copy link
Author

ohader commented Oct 6, 2020

IF this gets stuck, there's this fork. I'll be happy to review a PR.

I already did PHP 7.4 there IIRC.

Thx & good to know... reading other announcements of this project currently not being actively maintained would lead to the conclusion this PR is laying here forever. I'm a fan of try to centralize those things with the upstream repository.

Let's see, maybe there are also some possibilities (really) merging your compatibility changes into this repository...

@sanmai
Copy link

sanmai commented Oct 6, 2020

Well, if you could get a hand on that sweet merge button here, we can certainly try something. But, tbh, I was primarily concerned with jms/serializer using this package, which is no more...

@sanmai
Copy link

sanmai commented Oct 6, 2020

I'm a fan of try to centralize those things with the upstream repository.

I'd love that too, but considering that last PR was merged here in 2018, I'd say we'll have a tough luck here.

@ohader
Copy link
Author

ohader commented Oct 6, 2020

Well, if you could get a hand on that sweet merge button here, we can certainly try something. But, tbh, I was primarily concerned with jms/serializer using this package, which is no more...

I see, I also considered using a "hard-wired" parser, but then found this project again...
However I'm better in using (a)BNF-like terms to describe formats (a complicated format in my particular case) I gave it a try with hoa/compiler. Let's see 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants