-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[latest] Refactor PublushFlowHanderl, so, now we have two clear distinct paths… #505
Merged
tgracchus
merged 3 commits into
master
from
bugfix/22992-qos1-should-not-complete-qos2-flow/latest
Jun 20, 2024
Merged
[latest] Refactor PublushFlowHanderl, so, now we have two clear distinct paths… #505
tgracchus
merged 3 commits into
master
from
bugfix/22992-qos1-should-not-complete-qos2-flow/latest
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgracchus
changed the title
Refactor PublushFlowHanderl, so, now we have two clear distinct paths…
[latest] Refactor PublushFlowHanderl, so, now we have two clear distinct paths…
Jun 13, 2024
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Show resolved
Hide resolved
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Outdated
Show resolved
Hide resolved
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Outdated
Show resolved
Hide resolved
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Show resolved
Hide resolved
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Outdated
Show resolved
Hide resolved
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Outdated
Show resolved
Hide resolved
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Outdated
Show resolved
Hide resolved
hlohse
reviewed
Jun 17, 2024
src/test/java/com/hivemq/mqtt/handler/publish/PublishFlowHandlerTest.java
Outdated
Show resolved
Hide resolved
hlohse
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍 Only unit test nitpicks.
… for Qos1 and Qos2, Qos1 is using a map while Qos2 is using the IncomingMessageFlowPersistence
tgracchus
force-pushed
the
bugfix/22992-qos1-should-not-complete-qos2-flow/latest
branch
from
June 17, 2024 14:17
df6d5b9
to
d586ada
Compare
tgracchus
deleted the
bugfix/22992-qos1-should-not-complete-qos2-flow/latest
branch
June 20, 2024 07:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for Qos1 and Qos2, Qos1 is using a map while Qos2 is using the IncomingMessageFlowPersistence
Resolves #
https://hivemq.kanbanize.com/ctrl_board/42/cards/22992/details/