Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[latest] Refactor PublushFlowHanderl, so, now we have two clear distinct paths… #505

Merged

Conversation

tgracchus
Copy link
Contributor

@tgracchus tgracchus commented Jun 13, 2024

… for Qos1 and Qos2, Qos1 is using a map while Qos2 is using the IncomingMessageFlowPersistence

Resolves #
https://hivemq.kanbanize.com/ctrl_board/42/cards/22992/details/

@cla-bot cla-bot bot added the cla-signed label Jun 13, 2024
@tgracchus tgracchus changed the title Refactor PublushFlowHanderl, so, now we have two clear distinct paths… [latest] Refactor PublushFlowHanderl, so, now we have two clear distinct paths… Jun 13, 2024
@hlohse hlohse self-requested a review June 17, 2024 12:31
Copy link
Contributor

@hlohse hlohse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 Only unit test nitpicks.

… for Qos1 and Qos2, Qos1 is using a map while Qos2 is using the IncomingMessageFlowPersistence
@tgracchus tgracchus force-pushed the bugfix/22992-qos1-should-not-complete-qos2-flow/latest branch from df6d5b9 to d586ada Compare June 17, 2024 14:17
@tgracchus tgracchus merged commit d096393 into master Jun 20, 2024
2 checks passed
@tgracchus tgracchus deleted the bugfix/22992-qos1-should-not-complete-qos2-flow/latest branch June 20, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants