Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query param until_block not working in several endpoints #2101

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Oct 1, 2024

Closes #2099

The mutually-exclusive query param check for unanchored and until_block check had a regression from the Fastify refactor when unanchored was changed to default to false. This hotfix checks if the value is set to true rather than !== undefined.

Copy link

github-actions bot commented Oct 1, 2024

Vercel deployment URL: https://stacks-blockchain-65ai769jh-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zone117x zone117x merged commit fce15d6 into master Oct 1, 2024
27 checks passed
@zone117x zone117x deleted the fix/until-block-query-param branch October 1, 2024 15:20
blockstack-devops pushed a commit that referenced this pull request Oct 1, 2024
## [8.0.3](v8.0.2...v8.0.3) (2024-10-01)

### Bug Fixes

* query param `until_block` not working in several endpoints ([#2101](#2101)) ([fce15d6](fce15d6))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants