Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cenotaph column to runes #33

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

tippenein
Copy link
Contributor

tracks DbRune originating from cenotaph transactions

@tippenein tippenein changed the base branch from main to develop July 15, 2024 22:06
Copy link

github-actions bot commented Jul 15, 2024

Vercel deployment URL: https://runehook-qe0arnkq1-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files Patch % Lines
api/src/api/util/helpers.ts 0.00% 1 Missing ⚠️
api/src/pg/types.ts 0.00% 1 Missing ⚠️
src/db/models/db_rune.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but we should also add the API code to reflect this change. Let's go over it in our call tomorrow.

migrations/V5__add_cenotaph_to_runes.sql Outdated Show resolved Hide resolved
migrations/V1__runes.sql Outdated Show resolved Hide resolved
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@tippenein tippenein merged commit 3d8d21a into develop Jul 18, 2024
9 checks passed
@tippenein tippenein deleted the add-cenotaph-column-to-runes branch July 18, 2024 01:01
Copy link

🎉 This PR is included in version 0.3.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants