Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom network id #1905

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: allow custom network id #1905

merged 1 commit into from
Nov 12, 2024

Conversation

He1DAr
Copy link
Collaborator

@He1DAr He1DAr commented Nov 12, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Allow custom network id

Issue ticket number and link

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 3:10pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 3:10pm

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/common/components/modals/AddNetwork/utils.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@He1DAr He1DAr merged commit eaf11cb into main Nov 12, 2024
16 of 19 checks passed
@He1DAr He1DAr deleted the feat/allow-custom-network-id branch November 12, 2024 17:51
@blockstack-devops
Copy link

🎉 This PR is included in version 1.227.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants