-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: better eval hooks handling in contract calls #1575
Merged
hugocaillard
merged 7 commits into
main
from
refactor/eval-hooks-handling-in-contract-calls
Oct 9, 2024
Merged
refactor: better eval hooks handling in contract calls #1575
hugocaillard
merged 7 commits into
main
from
refactor/eval-hooks-handling-in-contract-calls
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
force-pushed
the
refactor/eval-hooks-handling-in-contract-calls
branch
from
October 4, 2024 17:22
de12923
to
4ac946a
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
hugocaillard
force-pushed
the
refactor/eval-hooks-handling-in-contract-calls
branch
from
October 9, 2024 11:13
3f64e6a
to
6723f1e
Compare
hugocaillard
commented
Oct 9, 2024
hugocaillard
commented
Oct 9, 2024
hugocaillard
commented
Oct 9, 2024
hugocaillard
commented
Oct 9, 2024
tippenein
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hugocaillard
deleted the
refactor/eval-hooks-handling-in-contract-calls
branch
October 9, 2024 21:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Refactoring how we handle the code coverage hook in the session, in order to make it easier to pass more hooks to the contract-calls. Should be merged before #1574
This also fixes some of the behavior in the PR:
simnet.runSnippet
andsnippet.execute
There's still room for improvement, but I think this a ready to start adding more hooks in the sdk