Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved stacking orders #1331

Merged
merged 17 commits into from
Jan 30, 2024
Merged

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Jan 25, 2024

Fixes #1302
Fixes #1303

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (99a5be5) 40.34% compared to head (2ff6347) 40.25%.

Files Patch % Lines
...omponents/stacks-network/src/chains_coordinator.rs 0.00% 105 Missing ⚠️
components/clarinet-files/src/network_manifest.rs 0.00% 39 Missing ⚠️
components/clarinet-cli/src/generate/project.rs 0.00% 2 Missing ⚠️
components/stacks-devnet-js/src/lib.rs 0.00% 1 Missing ⚠️
components/stacks-network/src/ui/ui.rs 0.00% 1 Missing ⚠️
components/stacks-rpc-client/src/rpc_client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1331      +/-   ##
===========================================
- Coverage    40.34%   40.25%   -0.09%     
===========================================
  Files           87       87              
  Lines        31612    31672      +60     
===========================================
- Hits         12755    12751       -4     
- Misses       18857    18921      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hugocaillard
hugocaillard previously approved these changes Jan 30, 2024
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @MicaiahReid! 🙌

@hugocaillard hugocaillard enabled auto-merge (squash) January 30, 2024 16:49
@hugocaillard hugocaillard merged commit b05d453 into develop Jan 30, 2024
19 checks passed
@hugocaillard hugocaillard deleted the feat/improved-stacking-orders branch January 30, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants