Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra { in tasks.json #1256

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

tippenein
Copy link
Collaborator

@tippenein tippenein commented Nov 16, 2023

fixes: #1245

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a0a563) 40.07% compared to head (1d50690) 40.07%.

Files Patch % Lines
components/clarinet-cli/src/generate/project.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1256      +/-   ##
===========================================
- Coverage    40.07%   40.07%   -0.01%     
===========================================
  Files           86       86              
  Lines        30836    30835       -1     
===========================================
- Hits         12359    12358       -1     
  Misses       18477    18477              
Flag Coverage Δ
unittests 40.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard
Copy link
Collaborator

Thanks a lot @tippenein
I updated the comment to link the PR to the issue

It will be included in the next release (I don't know exactly when but maybe next week)

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @tippenein

@hugocaillard hugocaillard merged commit 7f20e50 into hirosystems:develop Nov 16, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

clarinet new creates invalid .vscode\tasks.json
2 participants