Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): eliminate config side effects of render function #226

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

hikerpig
Copy link
Owner

Releated #215

Copy link

vercel bot commented Dec 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 1:20pm

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (87f80b1) 91.06% compared to head (75d84af) 91.39%.
Report is 94 commits behind head on master.

Files Patch % Lines
packages/pintora-diagrams/src/dot/artist.ts 92.20% 6 Missing ⚠️
packages/pintora-diagrams/src/util/arrow/index.ts 89.47% 6 Missing ⚠️
packages/pintora-diagrams/src/activity/artist.ts 92.30% 3 Missing ⚠️
packages/pintora-diagrams/src/sequence/artist.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   91.06%   91.39%   +0.33%     
==========================================
  Files          69       83      +14     
  Lines        3994     4686     +692     
  Branches      762      837      +75     
==========================================
+ Hits         3637     4283     +646     
- Misses        357      403      +46     
Flag Coverage Δ
unittests 91.39% <96.17%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikerpig hikerpig merged commit 718e47d into master Dec 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant