Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/configs-improvements #606

Open
wants to merge 11 commits into
base: stable
Choose a base branch
from
2 changes: 1 addition & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
node_modules/
dist/*
dist/
17 changes: 6 additions & 11 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
module.exports = {
root: true,
env: {
browser: true,
es2021: true,
node: true
node: true,
es2024: true
},
root: true,
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module'
Expand All @@ -24,13 +24,8 @@ module.exports = {
}
],
rules: {
'no-unused-vars': 0,
'import/no-cycle': 2,
'prettier/prettier': [
'error',
{
endOfLine: require('os').EOL === '\r\n' ? 'crlf' : 'lf'
}
]
'no-unused-vars': 'off',
'import/no-cycle': 'error',
'import/no-named-as-default': 'off'
}
};
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

#### Expected behaviour


#### Actual behaviour

<!-- screenshots welcome! -->

#### Reproduction steps
<!-- Please describe how to reproduce the issue. -->

<!-- Please describe how to reproduce the issue. -->
<!-- If you can, please include a curl fetch that demonstrates the issue, e.g. -->
<!-- curl -H "Content-Type: application/json" -X POST -d '{"infile":{ <CHART OPTIONS HERE> }' 127.0.0.1:7801 -o mychart.png -->

34 changes: 17 additions & 17 deletions .github/workflows/build-and-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,24 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout Repository
uses: actions/checkout@v4
- name: Checkout Repository
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '18.x.x'
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '18.x.x'

- name: Install Dependencies
run: npm ci
- name: Install Dependencies
run: npm ci

- name: Build Project
run: npm run build
- name: Build Project
run: npm run build

- name: Commit and Push /dist Directory
run: |
git config --local user.email "[email protected]"
git config --local user.name "GitHub Action"
git add -f dist/
git commit -m "Build the dist files after merge."
git push -f
- name: Commit and Push /dist Directory
run: |
git config --local user.email "[email protected]"
git config --local user.name "GitHub Action"
git add -f dist/
git commit -m "Build the dist files after merge."
git push -f
2 changes: 1 addition & 1 deletion .github/workflows/eslint-check.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: ESLint check

on: [ pull_request ]
on: [pull_request]

jobs:
eslint:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Unit tests

on:
pull_request:
branches: [ master ]
branches: [master]

jobs:
testing:
Expand All @@ -23,4 +23,4 @@ jobs:
- name: Run unit tests
run: npm run unit:test
env:
CI: true
CI: true
21 changes: 10 additions & 11 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,22 +1,21 @@
node_modules/
.cache/
.cert/
.vscode/
dist/
log/
tests/_temp
node_modules/
tmp/
dist/
.cert/
tests/_temp/
tests/**/_results/

.DS_Store
.cache
.vscode
.env
.eslintcache

tests/**/_results/

.DS_Store
resources.json

**/*.jpeg
**/*.jpg
**/*.png
**/*.pdf
**/*.svg
**/*.jpeg
**/*.log
2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
npm run lint
npx lint-staged
npm run unit:test
3 changes: 2 additions & 1 deletion .lintstagedrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"lib/**/\*.{js,json}": ["eslint", "npx prettier --write"]
"*.{js,ts}": ["npm run lint"],
"*.{json,css,md}": ["npm run format"]
}
5 changes: 3 additions & 2 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
node_modules/
dist/*
README.md
dist/

samples/cli/infile_not_json.json
7 changes: 0 additions & 7 deletions .prettierrc

This file was deleted.

8 changes: 8 additions & 0 deletions .prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
module.exports = {
trailingComma: 'none',
endOfLine: 'auto',
tabWidth: 2,
printWidth: 80,
semi: true,
singleQuote: true
};
Loading
Loading