-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer fixed on the bottom always #10
base: main
Are you sure you want to change the base?
Footer fixed on the bottom always #10
Conversation
✅ Deploy Preview for hiero-open-source ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@abinjustinkumaravel the DCO check is failing. The Linux Foundation has a rule that each commit must sign the Developer Certificate of Origin (DCO). In general that says that you are allowed to do the commit (legal text could be found here). To fix this afterwards for you commits you need to do the following steps (copied from DCO check Details):
Once that is done all checks should be green. |
0766fb9
to
673bc29
Compare
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: itsbrandond <[email protected]> Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
d697e8f
to
7979c33
Compare
@hendrikebbers Should I work for netlify green checks ? or we can leave it by neutral ? |
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
|
||
|
||
[[headers]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give some information about the additions in the netlify file. I have no idea what headers
and redirects
this does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think netlify rule is there, we need to add, headers
and redirects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I do not understand what you mean. Do you have a link to a documentation for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would help to refer to the documentation on redirect options provided by Netlify.
As you can see in the initial stage, the Redirects
and Headers
columns are in a neutral state—they don't have the green check mark. At that time, I checked the documentation, and it mentioned that you need to add redirects and headers in the configuration file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not needed, I can remove it from the configuration file. Let me know what to do.
public-key.asc
Outdated
@@ -0,0 +1,42 @@ | |||
-----BEGIN PGP PUBLIC KEY BLOCK----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what usecase do we need a public key? How is it generated? Who owns the private key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my local setup, I need to use PGP Key... I accidentally added it..
content/_index.md
Outdated
@@ -139,6 +139,15 @@ May Chan, CEO, <a href="https://www.hashpack.app/" target="_blank" rel="noreferr | |||
''' | |||
logo = "images/Hiero-Logo-HashPack.png" | |||
|
|||
[[section_quotes]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why this is shown as addition for the PR? Can you rebase on the main
and check if this goes away?
@abinjustinkumaravel I added some comments to the changes. Can you please check? |
I will check it and update you soon. |
Co-authored-by: Hendrik Ebbers <[email protected]> Signed-off-by: Abin Justin Kumaravel <[email protected]>
…into footer-fixed-on-bottom
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
This PR renames
hugo.toml
toconfig.toml
to fix the Hugo build issue and ensure correct configuration loading. It also updates the configuration file with properbaseURL
,languageCode
, andtitle
settings. Additionally, template references to.Site.LanguageCode
were fixed to resolve rendering errors, improving the overall site structure and build process.