Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer fixed on the bottom always #10

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

abinjustinkumaravel
Copy link

This PR renames hugo.toml to config.toml to fix the Hugo build issue and ensure correct configuration loading. It also updates the configuration file with proper baseURL, languageCode, and title settings. Additionally, template references to .Site.LanguageCode were fixed to resolve rendering errors, improving the overall site structure and build process.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for hiero-open-source ready!

Name Link
🔨 Latest commit 41f23dc
🔍 Latest deploy log https://app.netlify.com/sites/hiero-open-source/deploys/670c01187ff2a80008789693
😎 Deploy Preview https://deploy-preview-10--hiero-open-source.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hendrikebbers
Copy link
Contributor

@abinjustinkumaravel the DCO check is failing. The Linux Foundation has a rule that each commit must sign the Developer Certificate of Origin (DCO). In general that says that you are allowed to do the commit (legal text could be found here).

To fix this afterwards for you commits you need to do the following steps (copied from DCO check Details):

Once that is done all checks should be green.

abinjustinkumaravel and others added 5 commits October 7, 2024 01:38
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: itsbrandond <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
@abinjustinkumaravel
Copy link
Author

abinjustinkumaravel commented Oct 6, 2024

@hendrikebbers Should I work for netlify green checks ? or we can leave it by neutral ?

Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>


[[headers]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some information about the additions in the netlify file. I have no idea what headers and redirects this does.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think netlify rule is there, we need to add, headers and redirects

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I do not understand what you mean. Do you have a link to a documentation for that?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would help to refer to the documentation on redirect options provided by Netlify.

Netlify Redirect and Headers

As you can see in the initial stage, the Redirects and Headers columns are in a neutral state—they don't have the green check mark. At that time, I checked the documentation, and it mentioned that you need to add redirects and headers in the configuration file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not needed, I can remove it from the configuration file. Let me know what to do.

public-key.asc Outdated
@@ -0,0 +1,42 @@
-----BEGIN PGP PUBLIC KEY BLOCK-----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what usecase do we need a public key? How is it generated? Who owns the private key?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my local setup, I need to use PGP Key... I accidentally added it..

package-lock.json Outdated Show resolved Hide resolved
@@ -139,6 +139,15 @@ May Chan, CEO, <a href="https://www.hashpack.app/" target="_blank" rel="noreferr
'''
logo = "images/Hiero-Logo-HashPack.png"

[[section_quotes]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this is shown as addition for the PR? Can you rebase on the main and check if this goes away?

@hendrikebbers
Copy link
Contributor

@abinjustinkumaravel I added some comments to the changes. Can you please check?

@abinjustinkumaravel
Copy link
Author

@abinjustinkumaravel I added some comments to the changes. Can you please check?

I will check it and update you soon.

Co-authored-by: Hendrik Ebbers <[email protected]>
Signed-off-by: Abin Justin Kumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
Signed-off-by: abinjustinkumaravel <[email protected]>
@hendrikebbers hendrikebbers added the hacktoberfest-accepted Reserved for PRs that are accepted for Hacktoberfest (see https://hacktoberfest.com) 🚀👾🧑🏽‍💻 label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Reserved for PRs that are accepted for Hacktoberfest (see https://hacktoberfest.com) 🚀👾🧑🏽‍💻
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants