feat(tokenUpdateTransaction): Implement TokenUpdateTransaction E2E tests: TCK
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…nupdatetransaction
…ith the latest improvements in TokenCreateTransaction logic. Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
requested review from
rwalworth,
0xivanov,
agadzhalov and
gsstoykov
Signed-off-by: ivaylogarnev-limechain <[email protected]>
rwalworth
reviewed
Oct 31, 2024
| // } | ||
| // | ||
| // assert.fail("Should throw an error"); | ||
| //}); |
There was a problem hiding this comment.
Is this meant to be left commented?
There was a problem hiding this comment.
This was left commented out, and I haven't modified it. However, after testing it now, it appears it may have been commented because it throws an invalid expiration time error, even though it is within the acceptable range. I will look into the reason behind this.
…sary prototype change and removed .only Signed-off-by: ivaylogarnev-limechain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the
TokenUpdateTransactiontests documented intest-specifications/token-service/tokenUpdateTransaction.md. Currently a test is skipped because of a bug in the services code which is related with theint64 minvalue.Related issue(s):
#238
Checklist