Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokenDeleteTransaction): Implement TokenDeleteTransaction E2E tests: TCK #256

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR implements the TokenDeleteTransaction tests documented in test-specifications/token-service/tokenDeleteTransaction.md.

Related issue(s):

Fixes #243

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And all tests pass with C++ server

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any tests in this file require a signature from the operator key. Also the operator signs all of the transactions anyways since that's what we initialize the SDK server Client with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK: Implement tests for TokenDeleteTransaction
2 participants