feat: add Client::forMirrorNetwork() to allow consensus node network initialization with a mirror node address book
#805
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddress book Signed-off-by: Rob Walworth <[email protected]>
rwalworth
added
the
New Feature
Signed-off-by: Rob Walworth <[email protected]>
…an-addressbook-if-a-client-is-initialized-only-with-a-mirrornetwork
Signed-off-by: Rob Walworth <[email protected]>
jeromy-cannon
approved these changes
Oct 31, 2024
rwalworth
changed the title
Client.populateNetworkFromMirrorNodeAddressBook() to allow consensus node network initialization with a mirror node address bookClient::forMirroNetwork() to allow consensus node network initialization with a mirror node address book
rwalworth
changed the title
Client::forMirroNetwork() to allow consensus node network initialization with a mirror node address bookClient::forMirrorNetwork() to allow consensus node network initialization with a mirror node address book
…an-addressbook-if-a-client-is-initialized-only-with-a-mirrornetwork
gsstoykov
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a needed feature for SDKs that will be used for sphere: the ability to get the address book from a mirror node and use it to populate a
Client's consensus node network.Related issue(s):
Fixes #800
Checklist