-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework/simplify GH Actions jobs #9163
Conversation
* Use `pull_request` instead of `pull_request_target` * Move Develocity build scan publishing for untrusted code to a separate workflow * Merge Atlas workflow into the main CI workflow * Split caches between trusted and untrusted code * Update secrets to use "Develocity" name instead of "Gradle Enterprise" * Update comments Co-Authored-By: Yoann Rodière <[email protected]>
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
So that we're extra sure we're not relying on cache left by a previous Gradle execution.
Note the oracle_atps failure is unrelated, as it's been failing for a few days already: https://github.com/hibernate/hibernate-orm/actions/runs/11489734604/job/31980895415 |
EDIT: Wrong, see below. |
Actually that's wrong, since we change the name of the cache in this very PR. So, I think the GitHub runner just has some leftover build scans that don't get cleaned up between builds. Which makes you extra right to not trust these runners with secrets, @beikov , as the older build scans could be coming from anywhere. I'll add something to clean up the EDIT: Done |
Merging, since Christian had a look yesterday already. |
pull_request
instead ofpull_request_target
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.