-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix additional details extraction in ATK scraper #1320
base: main
Are you sure you want to change the base?
Conversation
Generally these changes are OK with me; the two things I'd like to figure out before merge are:
|
Normally, I believe backwards compatibility should be a priority, as long as it doesn't degrade performance. However, since it appears all the existing recipes have already been migrated to this new format (with all three test cases requiring updates to pass), it might not be necessary in this case. |
While developing the ATK scraper for v15 this was the initial format and I had to change it at least once during development. It might make sense to provide both until there is some confidence that it is stable. Though not sure how to discover that? Some |
Implements the fix recommended by @sudobash1 in #1317 and pulls new test data to represent current site structure/information.
Also, pulls new test data and updates tests for two related coverages,
cookscountry
&cooksillustrated
.Resolves #1317