Added scraper for Drinkoteket.se #1043
Conversation
Pebkac03
changed the title
Pebkac03
changed the title
Pebkac03
changed the title
| def yields(self): | ||
| return 1 |
There was a problem hiding this comment.
Thank you, @Pebkac03!
The only quibble I have is this return 1. I guess it makes sense that most/all of the recipes will be for a single instance of whatever cocktail is being prepared. Could you check for counter-examples even so?
There was a problem hiding this comment.
Thanks, you're right. Found that some recipes where for two servings. Will probably work on it tomorrow.
| else: | ||
| raw_list = ingredients_element.findAll("span")[0::2] | ||
|
|
||
| ingredients = [i.getText().strip() for i in raw_list] |
There was a problem hiding this comment.
A small cleanup suggestion:
| ingredients = [i.getText().strip() for i in raw_list] | |
| ingredients = [i.text.strip() for i in raw_list] |
|
Hi @Pebkac03, just a quick note. If you add |
|
Thanks, I will do that. I realized that the site has a tendency of not having a standard way of doing many things leading me to suspect a substantial risk of annoying edge cases requiring a lot of testing to be certain of it being bug-free which I currently do not have the time for. You could either merge it as is if you want, there are very few recipes with a differing serving amount or if you feel it needs to be more stable, mark it as a draft and I'll do it sometime in the future unless anyone else wants to contribute. |
I've added a scraper for Drinkoteket.se.
This one was a bit tricky with the ingredients since they don't provide amounts in their schema. This works by parsing a list from the HTML with ingredients and then removing everything below the separator since those elements aren't part of the ingredients.
Resolves #1042