Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HH-237393 service discovery: use force_allow_cross_datacenter_for_ups… #756

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontik/service_discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,13 @@ def __init__(self, statsd_client: Union[StatsDClient, StatsDClientStub], app_nam
upstream_cache.start()

allow_cross_dc = http_options.http_client_allow_cross_datacenter_requests
datacenters = http_options.datacenters if allow_cross_dc else (http_options.datacenter,)
for upstream, dc in itertools.product(options.upstreams, datacenters):
forced_cross_dc_upstreams = http_options.force_allow_cross_datacenter_for_upstreams

def cross_dc_or_forced(entry):
upstream, dc = entry
return allow_cross_dc or dc == http_options.datacenter or upstream in forced_cross_dc_upstreams

for upstream, dc in filter(cross_dc_or_forced, itertools.product(options.upstreams, http_options.datacenter)):
health_cache = HealthCache(
service=upstream,
health_client=self.consul.health,
Expand Down
Loading