HH-235648 use asyncio.queue to channel request chunks from tornado connection to asgi app #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-pertsev
commented
Oct 28, 2024
| @@ -186,6 +228,13 @@ def get_frontik_and_apps_versions(self) -> etree.Element: | |||
| def get_kafka_producer(self, producer_name: str) -> Optional[AIOKafkaProducer]: # pragma: no cover | |||
| pass | |||
|
|
|||
| def start_request( | |||
There was a problem hiding this comment.
как вариант - можно передавать в httpserver не фронтик-приложение, а объект-хендлер, в котором будет доступ к инстансу приложения
но я подумал сильной разницы нет - всве равно сейчас много где кишки торнады торчат
a-pertsev
commented
Oct 28, 2024
| @@ -12,7 +12,7 @@ | |||
| from frontik.testing import FrontikTestBase | |||
|
|
|||
|
|
|||
| class TestKafkaProducer: | |||
| class KafkaProducerMock: | |||
There was a problem hiding this comment.
иначе тесты ворнинги пишут
…nnection to asgi app
712u3
approved these changes
Oct 30, 2024
…ward compatibility
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.