HH-200040 fix getting preprocessor name #665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
colorbash
reviewed
Nov 29, 2023
| @@ -27,4 +27,6 @@ def get_preprocessors(func: Callable) -> list: | |||
|
|
|||
|
|
|||
| def make_full_name(func: Callable | Any) -> str: | |||
| if isinstance(func, Preprocessor): | |||
There was a problem hiding this comment.
а препроцессоры только в ххапи? может тогда там это переопределить?
There was a problem hiding this comment.
только в апи, обновил там
https://github.com/hhru/hhapi/pull/2977 посмотри плз
There was a problem hiding this comment.
есть еще вариант из апи вообще препроцессоры выпилить, но я вот не знаю хороший ли вариант, т.к.
- они там хорошо смотрятся тк только какие-то чеки делают, типа "is_employer" и не возвращают данных
- есть еще местные просто декораторы, не препроцессоры, их тоже в зависимости превращать?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.hh.ru/browse/HH-200040