HH-199730 little speed-up for set_status

hhru · Nov 25, 2023 · 5a0d4cb · 5a0d4cb
1 parent 2bcaf24
commit 5a0d4cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/frontik/handler.py b/frontik/handler.py
@@ -46,10 +46,6 @@
     from frontik.integrations.statsd import StatsDClient, StatsDClientStub
 
 
-def _fallback_status_code(status_code: int) -> int:
-    return status_code if status_code in ALLOWED_STATUSES else http.client.SERVICE_UNAVAILABLE
-
-
 class FinishWithPostprocessors(Exception):
     def __init__(self, wait_finish_group: bool = False) -> None:
         self.wait_finish_group = wait_finish_group
@@ -292,7 +288,7 @@ def _get_request_mime_type(self, request: HTTPServerRequest) -> str:
         return re.split(MEDIA_TYPE_PARAMETERS_SEPARATOR_RE, content_type)[0]
 
     def set_status(self, status_code: int, reason: str | None = None) -> None:
-        status_code = _fallback_status_code(status_code)
+        status_code = status_code if status_code in ALLOWED_STATUSES else http.client.SERVICE_UNAVAILABLE
         super().set_status(status_code, reason=reason)
 
     def redirect(self, url, *args, allow_protocol_relative=False, **kwargs):

diff --git a/frontik/http_status.py b/frontik/http_status.py
@@ -2,4 +2,4 @@
 
 CLIENT_CLOSED_REQUEST = 499
 NON_CRITICAL_BAD_GATEWAY = 569
-ALLOWED_STATUSES = [*list(http.client.responses.keys()), CLIENT_CLOSED_REQUEST, NON_CRITICAL_BAD_GATEWAY]
+ALLOWED_STATUSES = {*http.client.responses.keys(), CLIENT_CLOSED_REQUEST, NON_CRITICAL_BAD_GATEWAY}