Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): export APIResult when using serviceResponse as 'response' #283

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #282

@jordanshatford jordanshatford requested a review from mrlubos April 7, 2024 22:09
Copy link

vercel bot commented Apr 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2024 10:09pm

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.44%. Comparing base (801fb25) to head (515aaed).

Files Patch % Lines
packages/openapi-ts/src/utils/write/index.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   83.47%   83.44%   -0.04%     
==========================================
  Files          71       71              
  Lines        4647     4650       +3     
  Branches      513      514       +1     
==========================================
+ Hits         3879     3880       +1     
- Misses        767      769       +2     
  Partials        1        1              
Flag Coverage Δ
unittests 83.44% <33.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit b795730 into main Apr 7, 2024
14 of 16 checks passed
@jordanshatford jordanshatford deleted the fix/service-response-export branch April 7, 2024 22:21
@github-actions github-actions bot mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serviceResponse 'response' syntax error in generated code
2 participants