Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add url config validation #5578

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

ShaytonXu
Copy link
Contributor

@ShaytonXu ShaytonXu commented Nov 30, 2024

What does it do?

Add url config validation.
To resolve the issue. #5577

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

github-actions bot commented Nov 30, 2024

How to test

git clone -b feature/add-config-url-validation https://github.com/ShaytonXu/hexo.git
cd hexo
npm install
npm test

Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea LGTM, only a few questions.

lib/hexo/validate_config.ts Outdated Show resolved Hide resolved
@ShaytonXu ShaytonXu requested a review from SukkaW December 2, 2024 04:56
@uiolee uiolee merged commit 5db029a into hexojs:master Jan 7, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants