-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: localhost SSL support #341
base: master
Are you sure you want to change the base?
Conversation
@SukkaW review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I myself don't like the idea of pre-exists certificate.
What about using mkcert
of some sort?
|
Agreed, pre-exists certificate may be difficult to trust |
Then, what is the solution? Should auto certificate creation be made? |
Btw, this feature no need user to install the certificate into their computer. This certificate only for NodeJS http server. So, this feature does not harm its users. |
At least the certificate should be generated per hexo project and on users' computers. We can store the generated certificates under the You can refer to vercel/next.js#54016 for the implementation. They are utilizing
This is just not even remotely a good practice. Let's avoid it. |
check list
Description
fix #340
Add SSL support for localhost. [FEATURE REQUEST] issue
Additional information
accessing from custom local domain
accessing from https://localhost:4000
accessing from local network
homepage
gallery
post asset link
How to test
check it https://github.com/dimaslanjaka/hexo-themes