Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for macOS #19

Merged
merged 8 commits into from
Jul 5, 2024
Merged

feat: add support for macOS #19

merged 8 commits into from
Jul 5, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jul 3, 2024

Closes #18

@phm07 phm07 requested a review from a team as a code owner July 3, 2024 10:40
example/Makefile Outdated Show resolved Hide resolved
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few lock files can be removed.

cleanup.sh Outdated Show resolved Hide resolved
registry-port-forward.sh Outdated Show resolved Hide resolved
registry-port-forward.sh Outdated Show resolved Hide resolved
registry-port-forward.sh Outdated Show resolved Hide resolved
@jooola
Copy link
Member

jooola commented Jul 3, 2024

Did you try with the submit sub command (https://ss64.com/mac/launchctl.html):


     submit -l label [-p executable] [-o stdout-path] [-e stderr-path] --
              command [arg0] [arg1] [...]
              A simple way of submitting a program to run without a configuration
              file. This mechanism also tells launchd to keep the program alive in the event
              of failure.

              -l label
                       What unique label to assign this job to launchd.

              -p program
                       What program to really execute, regardless of what follows
                       the -- in the submit sub-command.

              -o stdout-path
                       Where to send the stdout of the program.

              -e stderr-path
                       Where to send the stderr of the program.

I believe it will be easier to manage.

@phm07
Copy link
Contributor Author

phm07 commented Jul 3, 2024

Did you try with the submit sub command (https://ss64.com/mac/launchctl.html):

Looks good! I think it doesn't have all of the options but it probably should be enough to work.

@phm07
Copy link
Contributor Author

phm07 commented Jul 3, 2024

It now works for me on my system. A weird bug I encountered is that KUBECONFIG won't be correct inside of the scripts.
It will still have the default value. For now I just used "$PWD/files/kubeconfig.yaml" instead.

registry-port-forward.sh Outdated Show resolved Hide resolved
registry-port-forward.sh Outdated Show resolved Hide resolved
example/Makefile Outdated Show resolved Hide resolved
@apricote apricote requested a review from jooola July 5, 2024 12:08
@jooola jooola force-pushed the launchd-support branch from de9234d to a140bd0 Compare July 5, 2024 13:32
@jooola jooola changed the title feat: add launchd support for macOS feat: add support for macOS Jul 5, 2024
@jooola jooola merged commit 4b6513e into main Jul 5, 2024
2 checks passed
@jooola jooola deleted the launchd-support branch July 5, 2024 13:38
jooola pushed a commit that referenced this pull request Jul 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](v0.4.0...v0.5.0)
(2024-07-05)


### Features

* add support for macOS
([#19](#19))
([4b6513e](4b6513e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow running registry port-forward on MacOS
3 participants