fix: change floating ip labels type to dict[str, str]
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
changed the title
dict[str, str]
|
Thanks for the fix! I'll merge this as soon as the CI passes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 64 64
Lines 2981 2981
=======================================
Hits 2768 2768
Misses 213 213 ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
Oct 8, 2024
jooola
pushed a commit
that referenced
this pull request
Oct 9, 2024
🤖 I have created a release *beep* *boop* --- ## [2.3.0](v2.2.1...v2.3.0) (2024-10-09) ### Features * support python 3.13 ([#451](#451)) ([4a514c7](4a514c7)) ### Bug Fixes * change floating ip labels type to `dict[str, str]` ([#444](#444)) ([1f6da4e](1f6da4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type for the floating ip label was wrong. Its now changed to the type in the comments and works as expected.